Skip to content

Fix NULL-pointer dereference on the genesis block during -reindex / import #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VictorLux wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix NULL-pointer dereference on the genesis block during -reindex / import #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4473,7 +4473,11 @@ bool AcceptBlockHeader(const CBlockHeader& block, CValidationState& state, CBloc
return false;


if (!pindexPrev->IsValid(BLOCK_VALID_SCRIPTS)) {
// pindexPrev is NULL for the genesis block (set only for non-genesis above).
// The genesis block has no ancestors, so the invalid-ancestor walk below is
// meaningless for it; guard the dereference to avoid a NULL segfault during
// -reindex / import, where LoadExternalBlockFile re-accepts the genesis header.
if (pindexPrev != NULL && !pindexPrev->IsValid(BLOCK_VALID_SCRIPTS)) {
for (const CBlockIndex *failedit : g_failed_blocks) {
if (pindexPrev->GetAncestor(failedit->nHeight) == failedit) {
assert(failedit->nStatus & BLOCK_FAILED_MASK);
Expand Down
Loading