Run the test suite in CI, not just build+lint - #7
Merged
Conversation
CI built and linted every PR but never ran the real test suite (20 tests, added earlier this session - this repo had none before). Confirmed vitest correctly runs once-and-exit under CI=true (which GitHub Actions sets automatically), rather than its local default of watch mode. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DTXXBERPGEnYiYP4Mt3FjF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI built and linted every PR across 3 Node versions, but never ran the real test suite — this repo had no tests at all until earlier this session (20 tests, 100% stmt/line/func coverage). Adds a `Test` step running `npm test`.
Confirmed locally that vitest correctly runs once-and-exits under `CI=true` (its local default without that is watch mode, which would hang a runner) — GitHub Actions sets `CI=true` automatically, so no other change was needed.
Test plan