Security: Authentication tokens stored in localStorage (XSS-exfiltration risk)#102
Open
tomaioo wants to merge 1 commit into
Open
Conversation
Access and refresh tokens are persisted in `localStorage`. Any successful XSS in the web app or third-party script compromise can read and exfiltrate these tokens, leading to account takeover and session hijacking. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Authentication tokens stored in localStorage (XSS-exfiltration risk)
Problem
Severity:
High| File:web/features/auth/store.ts:L8Access and refresh tokens are persisted in
localStorage. Any successful XSS in the web app or third-party script compromise can read and exfiltrate these tokens, leading to account takeover and session hijacking.Solution
Store session tokens in secure, HttpOnly, SameSite cookies managed by the backend. Avoid exposing refresh tokens to JavaScript. If migration is gradual, at minimum reduce token lifetime and enforce CSP + strong XSS defenses.
Changes
web/features/auth/store.ts(modified)