Skip to content

docs: correct ARP table tactics + supersede stale MITRE design doc#308

Merged
Zious11 merged 1 commit into
developfrom
docs/f7-mitre-tactic-doc-fixes
Jun 23, 2026
Merged

docs: correct ARP table tactics + supersede stale MITRE design doc#308
Zious11 merged 1 commit into
developfrom
docs/f7-mitre-tactic-doc-fixes

Conversation

@Zious11

@Zious11 Zious11 commented Jun 23, 2026

Copy link
Copy Markdown
Owner

docs: correct ARP table tactics + supersede stale MITRE design doc

Branch: docs/f7-mitre-tactic-doc-fixes
Base: develop
Severity: MINOR (documentation only)
Behavior change: None — documentation corrections only, no code touched


Summary

F7 consistency-audit follow-up for issue #64 / ICS-tactic-fix feature. Two documentation
corrections that reconcile ARP-detection user-facing docs and the now-superseded MITRE
design spec with the ICS-tactic corrections adopted during F5.


What Changed

File Change
README.md ARP detection table: corrected the "Tactic" column for D1 (ARP spoofing) and D12 (L2/L3 sender-MAC mismatch) rows from the technique name "Adversary-in-the-Middle" to the correct tactic label "Collection (ICS), Credential Access" — aligning with the post-F5 ICS-matrix corrections.
docs/superpowers/specs/2026-04-13-mitre-attack-mapping-design.md Added a SUPERSEDED banner documenting that the single-Discovery-variant design was not adopted, ICS Discovery is TA0102 (not TA0111 as the original text stated), and T0830 maps to Collection (not Lateral Movement). Also corrected the inline TA-id reference TA0111 → TA0102 in the "known limitation" paragraph.

Root Cause

The F5 phase adopted dedicated ICS-matrix MitreTactic variants with correct TA-IDs.
Two documentation artefacts were not updated at that time:

  1. The README ARP table still used the technique name "Adversary-in-the-Middle" in the
    Tactic column instead of the correct ICS tactic names "Collection (ICS), Credential
    Access".
  2. The original MITRE mapping design doc contained a stale TA-id (TA0111 for ICS Discovery)
    that was never corrected, and no supersession notice was added when the implementation
    diverged from the design.

Architecture Changes

None. This PR touches only Markdown documentation files.

graph TD
    F5[F5: ICS tactic-ID correctness fix] --> README[README.md ARP table corrected]
    F5 --> DesignDoc[MITRE design doc superseded]
    F7[F7 consistency audit] --> README
    F7 --> DesignDoc
Loading

Story Dependencies

No story dependency. This is an ad-hoc F7 consistency-audit documentation fix.

graph LR
    Issue64[Issue #64 ICS-tactic-fix] --> ThisPR[docs/f7-mitre-tactic-doc-fixes]
    PR307[PR #307: fix ICS-matrix tactic IDs] --> ThisPR
Loading

Spec Traceability

No behavioral contracts apply (docs-only change).

flowchart LR
    F5["F5: ICS tactic adoption"] --> BC["BC-2.16.004 (ARP/DNP3 ICS tactic)"]
    BC --> README_fix["README.md tactic column fix"]
    BC --> DesignDoc_fix["Design doc superseded"]
Loading

Test Evidence

No tests required or modified. This is a documentation-only change.

  • cargo test --all-targets: not required to re-run (zero Rust source changes)
  • cargo clippy --all-targets -- -D warnings: N/A (no Rust code changed)
  • cargo fmt --check: N/A (no Rust code changed)

Demo Evidence

Not applicable — no behavior change, no UI/CLI output change.

Security Review

Skipped — docs-only PR. No code, no secrets, no config changed. Diff verified:
2 Markdown files, 23 insertions, 3 deletions. No executable content.

Holdout Evaluation

N/A — evaluated at wave gate.

Adversarial Review

N/A — evaluated at Phase 5.

Risk Assessment

  • Blast radius: Zero. Markdown-only changes with no effect on runtime behavior.
  • Performance impact: None.
  • Rollback: Trivial — revert the commit.

AI Pipeline Metadata

  • Pipeline mode: Ad-hoc F7 consistency fix (docs)
  • Models used: claude-sonnet-4-6 (pr-manager)
  • Branch HEAD: 05ef2ba

Pre-Merge Checklist

  • Branch uses semantic naming (docs/f7-mitre-tactic-doc-fixes)
  • PR title uses allowed semantic type (docs)
  • Docs-only: no Rust source changes
  • No secrets or credentials in diff
  • ARP tactic column corrected in README.md (D1, D12: "Collection (ICS), Credential Access")
  • MITRE design doc superseded with correct TA-id (TA0102 not TA0111)
  • Consistent with PR fix: correct ICS-matrix tactic IDs for ICS techniques in mitre_attack/grouped output #307 / BC-2.16.004 authoritative tactic assignments
  • CI checks pass (pending)
  • PR reviewer approved (pending)

…7 consistency)

F7-CV-001: README.md ARP detection table — D1 and D12 rows had "Adversary-in-the-Middle"
in the Tactic column, which is the technique name not the tactic. T0830 (ICS) maps to
Collection/TA0100; T1557.002 (Enterprise) maps to Credential Access/TA0006. Both rows
now show "Collection (ICS), Credential Access".

F7-CV-003: 2026-04-13 MITRE design spec — add SUPERSEDED banner (F5 ICS tactic-ID fix
deprecated the single-Discovery-variant approach; T0855/T0856 were remapped in v19).
Correct inline factual error TA0111 -> TA0102 for ICS Discovery with inline note.
@Zious11 Zious11 merged commit 760b6ca into develop Jun 23, 2026
10 checks passed
@Zious11 Zious11 deleted the docs/f7-mitre-tactic-doc-fixes branch June 23, 2026 18:13
@Zious11 Zious11 mentioned this pull request Jun 23, 2026
8 tasks
Zious11 added a commit that referenced this pull request Jun 23, 2026
Decision D-216 recorded: F7 delta-convergence APPROVED; docs PR #308
MERGED to develop (760b6ca); feature cycle feature-mitre-json-names
CONVERGED across all 5 dimensions; human authorized close cycle +
release v0.9.4; release prep in progress.

Updates:
- develop_head: 029725b760b6ca (PR #308 merge commit)
- phase_status: F7 CONVERGED (D-216), cycle CONVERGED, v0.9.4 IN PROGRESS
- Phase Progress F7 row: IN PROGRESS → COMPLETE/CONVERGED (D-216)
- Decisions Log: D-216 added
- GROUND-TRUTH HEADs block updated to D-216
- Status section: FEATURE CYCLE CONVERGED
- current_wave, WARNING block, Notes section updated

Count-propagation sweep: no artifact count changes in this burst;
sweep not applicable (pure state/decision update).
Zious11 added a commit that referenced this pull request Jun 23, 2026
Release v0.9.4 — mitre_attack JSON enrichment (#306), ICS-matrix tactic ID correctness fix (#307), doc fixes (#308).
Zious11 added a commit that referenced this pull request Jun 24, 2026
…eased, pipeline quiesced

Written durable SAFE-TO-CLEAR checkpoint (D-218). Session that delivered
v0.9.4 (feature-mitre-json-names: issue #64 mitre_attack + ICS tactic-ID
correctness fix) is complete and CLOSED.

Ground truth: develop=0115d0e, main=96b49e8 (tag v0.9.4), 0 open PRs,
worktrees=main+.factory only, pipeline quiesced. Stories delivered: 78.

WARNING/DO-NOT-REDO section added for: feature-mitre-json-names cycle
(PRs #306/#307/#308), v0.9.4 release, ICS tactic fix, issue-triage comments.
OPEN ITEMS table expanded with INPUT-HASH-STALE, ENGINE-IMPROVEMENT-BACKLOG,
ISSUE-TRIAGE-OPEN-9 rows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant