Document Hearthstone client, live-feature, performance and overlay architecture - #7
Merged
Merged
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что изменено
Power.log,LoadingScreen.log, coarseArena.log, HWND и reference data; чувствительные сетевые/account logs запрещены для ingestion и diagnostics;CapabilityStatus:Verified,Partial,ProviderRequired,Unavailable,Blocked.Ключевые технические выводы
Arena draft живёт до
GAMEPLAYв account/menu части клиента: обычные Power/Arena logs надёжно дают scene/coarse state, но не гарантируют содержимое hero/card offers. Поэтому автоматический Arena picker требует отдельного разрешённогоIArenaObservationProvider.Battlegrounds проходят внутри entity/tag game-state stream. Hero offers/choice, фазы, своя доска, quests/trinkets, next opponent и раскрытая доска соперника могут быть log-derived после фиксации build-specific fixtures. Stats API и simulator остаются enrichment и не меняют observed state.
Производительный путь определён как bounded log channels → allocation-aware parser → single-writer reducer → snapshot coalescer → bounded IPC → immutable WPF view state. UI обновляется не чаще 20 Hz; images декодируются по display size вне UI thread; simulation изолируется worker/process и отменяется при stale generation.
Внутриигровая подсветка не взаимодействует с Unity UI напрямую. Renderer использует HWND client rect, DPI и versioned normalized anchors. Live/Inspect остаются click-through; только явно включённый Layout edit принимает input. Unknown build/aspect/profile всегда скрывает callout.
Friendly UX
Безопасность и clean-room
Net.log,GameNetLogger.log,Hearthstone.log,Login.log;Decks.logдопускается только как отдельный локальный opt-in;Проверки
validate_feature_spec.ps1;tools/validate_repository.ps1: restore/build/test/vulnerability checks passed;git diff --checkpassed;Release-gate
PASS WITH LIMITATIONS: research, contracts and automated gates passed. Performance budgets are targets, not achieved claims. 100,000-line replay, WPF visual trace, HWND/DPI/click-through matrix, screenshot UX audit and live BG/Arena smoke remain gated on runtime implementation and redacted fixtures. Arena offers remainProviderRequired; patch-sensitive BG features remainPartialuntil fixtures pass.