Skip to content

Small changes to improve compatibility. - #7

Open
MilchRatchet wants to merge 3 commits into
Zunawe:mainfrom
MilchRatchet:main
Open

Small changes to improve compatibility.#7
MilchRatchet wants to merge 3 commits into
Zunawe:mainfrom
MilchRatchet:main

Conversation

@MilchRatchet

@MilchRatchet MilchRatchet commented Dec 30, 2023

Copy link
Copy Markdown

I added const qualifiers to all applicable function parameters. This helps in cases where the input buffer is only available through const qualified pointers.

I also added extern C to all function declarations so that the library can be accessed from C++ code.

As suggested in an issue, I moved some C standard library includes into the source file to avoid cluttering other translation units with unnecessary headers.

Closes #5
Closes #6

@MilchRatchet MilchRatchet changed the title Added const qualifiers and extern C for better compatibility. Small changes to improve compatibility. Dec 30, 2023
@ceggers-arri

Copy link
Copy Markdown

Just checked out m5-c the first time today. It run fine on my STM32F2 :-)

But I needed to perform the same changes as in the PR in order make it work for me, so I encourage to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary header includes Why not use const input argument?

2 participants