Document durable admission assessments and risk-aware shadow policy - #185
Merged
Conversation
Documents the previously-undocumented durable admission assessments (#159) and risk-aware shadow admission policy (#158) subsystems in docs/design.md and README.md, and fixes drift found across a systematic audit of every doc against its corresponding implementation: - .env.example: add 22 settings that existed in engram/config.py but were missing from the example file (admission capture, relationship- aware recall tuning, anti-feedback penalties, portal enrollment, provisioner role); note ENGRAM_HOST/ENGRAM_PORT are currently dead config (engram serve and the Docker image hardcode 0.0.0.0:8000). - docs/deployment.md: add a full "Recall tuning" section, document the provisioner role env var and portal enrollment toggle, note the dead host/port settings. - docs/embeddings.md: document `engram setup-embeddings` and two undocumented backfill flags. - docs/usage-metering.md: add two missing event types and a missing cost field to the telemetry taxonomy. - docs/service-provisioning.md: fix an incomplete service-permission list (was missing delegation.review.issue). - adapters/mcp-server/README.md: document engram_assessments and engram_reassess tools; fix stale engram_remember/engram_diary_write parameter descriptions. - adapters/engram-hooks/README.md: document a missing env var and correct the secret-screening description. - README.md: fix the "Explicitly deferred" list still claiming the CCA/MemPalace production migration (BL-011) was pending when it completed 2026-09-01 per the backlog; flip its capability-matrix row to dogfood-verified. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EEb5QpuqsPoTo6ZPjqn6Ah
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive documentation for two major admission-control features and updates deployment/configuration guidance across multiple docs.
Summary
Adds design documentation, deployment configuration, and API reference updates for:
Key Changes
ENGRAM_PROVISIONER_DATABASE_ROLEconfiguration requirementENGRAM_HOST/ENGRAM_PORT(currently dead code, always bind0.0.0.0:8000)engram_assessmentsandengram_reassesstool documentationengram_diary_writeto document admin representation viaon_behalf_of_principal_idand deprecate legacyprincipalparameterpublicoptionengram setup-embeddingsvalidation command documentation and clarified activation coverage threshold configurationdelegation.review.issuepermission for purpose-bound review brokersENGRAM_HOOKS_REPORT_LIFECYCLE_TELEMETRYconfiguration optionextractionImplementation Status
Both features are documented as:
ENGRAM_ADMISSION_ASSESSMENT_CAPTURE_ENABLEDflag; production behavior unchanged when disabledpath_a_compatremains sole authoritative profileAll documentation includes explicit notes that these are observability/audit features that do not change promotion thresholds, weights, or lane rules.
https://claude.ai/code/session_01EEb5QpuqsPoTo6ZPjqn6Ah