Skip to content

Added a more detailed python example with prefix silence and parameters match Gradio#173

Open
coezbek wants to merge 3 commits into
Zyphra:mainfrom
coezbek:sample_adv
Open

Added a more detailed python example with prefix silence and parameters match Gradio#173
coezbek wants to merge 3 commits into
Zyphra:mainfrom
coezbek:sample_adv

Conversation

@coezbek
Copy link
Copy Markdown
Contributor

@coezbek coezbek commented Mar 4, 2025

No description provided.

Comment thread zonos/utils.py
# return torch.device("mps")
device_index = torch.cuda.current_device()
major, minor = torch.cuda.get_device_capability(device_index)
if major >= 7:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not compatible with PyTorch for AMD GPUs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me how to improve the patch? What kind of error do you get?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misspoke, this shouldn't affect the ROCm side of things,
major, minor = torch.cuda.get_device_capability(device_index) returns the compute version of the card (Major: 10, Minor: 3, for gfx1030 i.e. RX 6800xt)

Having major >= 7 encompasses pretty much any AMD GPU after 2013

Originally I thought it would return the ROCm version installed but I was incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants