Debug MPS#215
Closed
Aedelon wants to merge 1 commit into
Closed
Conversation
Author
|
==> #190 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: THIS IS A BAD WORK AROUND. SEE SOLUTION AND DISCUSSION HERE
Debug MPS Compatibility in Two Locations
This PR includes two fixes to ensure compatibility with the MPS backend (Apple Silicon) in PyTorch:
_1. Fix in backbone/_torch.py (Lines 137–138):
The F.scaled_dot_product_attention function is still not supported on MPS. This patch forces tensors to CPU in that case, avoiding runtime errors._
Switching from MPS to CPU and back to MPS significantly reduces training speed.
This is just a temporary workaround to uncover other issues. Please do not consider this PR for merging.
2. Fix in model.py (Lines 238–243):
The default backend (inductor) used by torch.compile is not supported on MPS. This change conditionally switches the backend to aot_eager when the selected device is MPS.
These adjustments allow the model to run properly on Apple devices using the MPS backend.