Skip to content

feat: office install runs install.sh - #71

Merged
hannesreinsch merged 1 commit into
mainfrom
feat/office-install
Sep 11, 2026
Merged

hannesreinsch merged 1 commit into
mainfrom
feat/office-install

Conversation

@hannesreinsch

@hannesreinsch hannesreinsch commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Adds office install [--theme]: runs ./install.sh (idempotent). It starts nothing.

Why: zyx, murmurflow and office now share five verbs with one meaning each:
install (set up, start nothing) · on · off · update · doctor.
Office already had on, off, update, doctor; install was the gap. Before this, office install fell through to the fuzzy repo match.

  • install is in the unzoom-exemption list (it moves no pane).
  • CI: the second fresh-HOME install now runs bin/office install.
  • Checked locally: all eight probes in bin/ pass (each run with env -u TMUX); office install run twice on a throwaway HOME + TMUX_TMPDIR gives one line in .zshrc, one in .tmux.conf, and the ~/.local/bin/office link. No tmux version guard needed (no tmux call added).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added the office install [--theme] command to re-run installation, rewire office into zsh and tmux, and safely accept installation options.
    • The command does not start any sessions or processes.
  • Documentation

    • Documented the new install command and its supported options in the command reference and built-in help.

The same verb as zyx and murmurflow: set it up, start nothing.
`office install [--theme]` runs ./install.sh, which is idempotent.
Before this the word fell through to the fuzzy repo match and looked
for a repo called "install".

CI's second fresh-HOME install now goes through `office install`.
All eight probes in bin/ pass locally.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0afaac55-fbd8-4ef1-8c71-18de717f91c1

📥 Commits

Reviewing files that changed from the base of the PR and between 3397e1b and b416ee8.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • README.md
  • office.zsh

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR adds an office install command that invokes install.sh with trailing arguments. It updates help text and documentation. CI now validates the command during the second installation run.

Changes

Office install command

Layer / File(s) Summary
Install command handling
office.zsh
The office function recognizes install, skips unzooming, and invokes install.sh with trailing arguments. Help text and header comments document the command.
Documentation and CI validation
README.md, .github/workflows/ci.yml
The Commands table documents office install [--theme]. CI uses bin/office install for the second installation run.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Office as office install
  participant InstallScript as install.sh
  participant ShellTmux as zsh and tmux
  Office->>InstallScript: Invoke with trailing arguments
  InstallScript->>ShellTmux: Rewire office
Loading

Merge Risk: ⚪ Minimal · up to b416e

The new install command is documented, forwards installer options, and is exercised by CI without identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: adding office install to run install.sh.
Description check ✅ Passed The description explains the change, motivation, behavior, CI update, and local verification results. It provides the required verification information, although it does not use the exact template hea…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/office-install

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hannesreinsch
hannesreinsch merged commit 5b98beb into main Sep 11, 2026
4 of 5 checks passed
@hannesreinsch
hannesreinsch deleted the feat/office-install branch September 11, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant