ci: fix test workflow to fail on actual errors#7
Merged
Conversation
Deploy GitHub infrastructure (CODEOWNERS, dependabot, CodeQL, secret-scan, PR/issue templates, release-drafter, stale management, pyright config) per SOP--the-descent-protocol.md tier requirements. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove continue-on-error and || echo guards that silently swallowed pytest and ruff failures. Update actions/checkout to v6. Fix test_main_runs assertion to use date.today() instead of hardcoded date that drifted from the mock's period.end value. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
continue-on-error: truefrom test job — checks were always passing regardless of test/lint results|| echoguards on pytest and ruff steps that swallowed failurestest_github_activity.py::test_main_runsthat hardcoded2026-03-05instead of usingdate.today()actions/checkoutfrom v4 to v6Context
Branch protection requires status checks
test (3.10)andtest (3.12). The workflow already produces these job names via matrix strategy, butcontinue-on-error: truemeant the checks never actually gated anything.Test plan
test (3.10)andtest (3.12)check namesGenerated with Claude Code