ASan env changes#1
Merged
Merged
Conversation
Signed-off-by: Sambhav Jain <sambhav@alumni.stanford.edu>
Signed-off-by: Sambhav Jain <sambhav@alumni.stanford.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors how sanitizer environment variables are passed for ASan builds.
Bake LSAN suppressions into CMake (
FusilliTestUtils.cmake)LeakSanitizer suppressions (
build_tools/sanitizers/lsan_suppressions.txt) arenow automatically set via
LSAN_OPTIONSin theENVIRONMENTproperty of allCTest targets (tests, samples, and benchmarks) when
FUSILLI_ENABLE_ASAN=ON.This eliminates the need for users or CI to manually pass
LSAN_OPTIONSas anenvironment variable.
Drop
ASAN_SYMBOLIZER_PATHfrom CI (build-and-test-linux.yml)Removed hardcoded
ASAN_SYMBOLIZER_PATHfrom the CI matrixasan-envfor bothgfx942_clang22_asanandcpu_clang18_asanconfigurations. The symbolizer isexpected to be on
PATHin the Docker environment.Keep
ASAN_OPTIONSas an environment variableASAN_OPTIONS(e.g.,detect_leaks=1:halt_on_error=0) remains a runtimeenvironment variable in CI since these are tunable knobs that vary by context.
README updates
section).