refactor: Decouple and deprecate core locale, plumb via catalog factory#1610
Open
jacobsimionato wants to merge 3 commits into
Open
refactor: Decouple and deprecate core locale, plumb via catalog factory#1610jacobsimionato wants to merge 3 commits into
jacobsimionato wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors locale configuration by moving it from the surface/context level to the catalog level. It introduces factory functions (such as createBasicCatalogFunctions) to allow instantiating catalog functions with a specific locale, while deprecating the legacy locale properties on DataContext and SurfaceModel. Feedback on these changes highlights that the subclass BasicCatalog in Angular has a parameterless constructor, which prevents configuring the locale when it is injected via Angular DI. It is recommended to update BasicCatalog to accept options via an InjectionToken to support proper dependency injection configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request decouples the
localeparameter from core models (SurfaceModelandDataContext) and plumbs it directly via a localized basic catalog function factory inside@a2ui/web_core/v0_9/basic_catalog.By deprecating the legacy, core-level parameters and providing a localized factory (
createBasicCatalogFunctions), we:BASIC_FUNCTIONS).@a2ui/angular's options).Fixes #1609
Pre-launch Checklist