Fix: Repair setup script, dependencies, and test suite - #2
Open
aaaronmiller wants to merge 1 commit into
Open
aaaronmiller wants to merge 1 commit into
aaaronmiller wants to merge 1 commit into
Conversation
This commit resolves multiple issues that rendered the application non-functional. The `setup.sh` script was failing during the Playwright browser installation due to an incorrect system dependency check. This was fixed by removing the `--with-deps` flag, allowing the setup to complete. The backend server was crashing on startup due to a missing `psutil` package. This dependency has been added to `requirements.txt`. The E2E tests, while passing, produced numerous warnings because the navigation link selectors were incorrect for a `HashRouter`-based application. The selectors in the test suite have been updated to match the application's routing scheme, resulting in a clean test run. These changes restore the project to a working state, allowing the servers to run and the E2E tests to pass successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit resolves multiple issues that rendered the application non-functional.
The
setup.shscript was failing during the Playwright browser installation due to an incorrect system dependency check. This was fixed by removing the--with-depsflag, allowing the setup to complete.The backend server was crashing on startup due to a missing
psutilpackage. This dependency has been added torequirements.txt.The E2E tests, while passing, produced numerous warnings because the navigation link selectors were incorrect for a
HashRouter-based application. The selectors in the test suite have been updated to match the application's routing scheme, resulting in a clean test run.These changes restore the project to a working state, allowing the servers to run and the E2E tests to pass successfully.