Skip to content

Use loop form in orderedMin4 to enable inlining #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aalpar merged 1 commit into from
Mar 8, 2026
Merged

Use loop form in orderedMin4 to enable inlining #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 11 additions & 19 deletions ordered.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,28 +282,20 @@ func orderedMin3[T cmp.Ordered](items []T, l int, min bool, i, j, k int) int {

// orderedMin4 finds the extremum among up to 4 consecutive elements
// starting at index i.
//
// Uses a loop instead of unrolled comparisons so the compiler's
// inlining cost stays under the budget (the unrolled form costs 130;
// budget is 80).
func orderedMin4[T cmp.Ordered](items []T, l int, min bool, i int) int {
q := i
i++
if i >= l {
return q
}
if orderedLess(items, min, i, q) {
q = i
}
i++
if i >= l {
return q
end := i + 4
if end > l {
end = l
}
if orderedLess(items, min, i, q) {
q = i
}
i++
if i >= l {
return q
}
if orderedLess(items, min, i, q) {
q = i
for i++; i < end; i++ {
if orderedLess(items, min, i, q) {
q = i
}
}
return q
}
Expand Down
Loading