docs(plans): mark numeric loss signals plans complete#756
Merged
Conversation
Updates both plan documents to reflect the three-PR completion: - Status field: 'Plan ready to start' / 'Approved by user' → 'Complete — all three PRs merged' with the three merge-commit references (#753 / #754 / #755) and dates. - Impl plan gains a 'Post-implementation outcome' section capturing shipped-vs-planned deltas: Declined: - LookupNumericSpec → Lookup rename (kept for cross-package clarity, 5 internal call sites all stable). Emerged during implementation: - atan2Operand helper in extensions/math/prim_transcendental.go (R7RS regression mitigation when helpers.ToFloat64 tightened). - runOne test helper created in PR 3, then deleted in PR 3 fixup after a 3-lens crosscheck convergence caught it as duplicating the existing eval helper. - Discoverability test (TestLossSignalDiscoverability) added in PR 3 fixup after the tests lens flagged a typo-risk gap. Plus LOC actuals (all PRs landed larger than estimated, mostly due to docs + integration test + post-review fixups), bench-gate results (PR 2 geomean +0.26%, within the 0.5% target), and review-findings summaries from both Copilot and the crosscheck agents. - Done definition checklist: 3/4 items checked. The fourth item (move both plans to memory/ per plans/CLAUDE.md convention) remains open as a separate closeout sweep. The cross-references section enumerates the user-visible documentation that ships with this work (docs/numeric/tower.md, docs/reference/r7rs-differences.md, values/CLAUDE.md, CHANGELOG.md) so a future reader can find the rule statement without re-tracing plan history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In-place update to the two numeric-loss-signals plan documents now
that all three PRs (#753, #754, #755) are merged.
plans/2026-05-14-numeric-loss-signals-design.md):Status field flipped from "Approved by user; refined" to "Complete
— all three PRs merged" with the three merge-commit references and
a note about the atan2 R7RS regression mitigation.
plans/2026-05-14-numeric-loss-signals-impl.md):Status field + done-definition checklist updated; new
"Post-implementation outcome" section captures shipped-vs-planned
deltas (including the declined
LookupNumericSpecrename, theemergent
atan2Operandhelper, therunOne-helper round-trip,the discoverability test), LOC actuals, bench-gate results, and
the review-findings summary.
Pure documentation; no code change.
Test plan
make lint/make testnot requireddocs/reference/r7rs-differences.md, values/CLAUDE.md,
TODO.md tier-5 entry)
Follow-up
The "Done definition" checklist has one open item: move both plans
to
memory/perplans/CLAUDE.mdconvention. Deferred to aseparate closeout sweep so this PR stays scoped to the in-place
update.
🤖 Generated with Claude Code