fix(send): require explicit --broadcast for AI-tool broadcasts#94
Open
zane668 wants to merge 1 commit into
Open
fix(send): require explicit --broadcast for AI-tool broadcasts#94zane668 wants to merge 1 commit into
zane668 wants to merge 1 commit into
Conversation
No-@target sends from inside an AI tool silently became broadcasts, and the soft preview guard was bypassed by a habitual --go and skipped entirely for <=3 recipients. Real incident: an agent's empty shell var turned a targeted send into an all-agents broadcast. Broadcast authorization is now its own opt-in: 'hcom send --broadcast'. --go no longer implies everyone; recipient count no longer matters. Human (non-AI-tool) CLI behavior is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Session: 019f670f-78bf-7b72-95c5-ab7fb1b23700 Producer: ai-session Tool: codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--broadcastflag for no-target sends made from inside an AI tool--goor a small recipient count as broadcast authorizationsend --helpand the broadcast preview to show the new opt-inThis closes a failure mode where a missing target argument, such as an empty shell variable, silently woke every active agent. The dedicated flag makes the high-fanout action explicit without adding new restrictions to normal targeted delivery.
Verification
cargo fmt --all -- --checkcargo clippy --all-targets --all-features --locked -- -D warningscargo test --locked: 1970 unit tests and 21 CLI smoke tests passed; 0 failed--gorejection, explicit--broadcast, the former two-recipient bypass, and help textUpstream CI baseline
Current
mainhas independent Rust 1.97 Clippy and cargo-dist workflow failures addressed by #91. This PR deliberately does not include those baseline changes; it should be refreshed after #91 lands.