Skip to content

Calculate National Ice Cream Day on third Sunday - #10

Merged
aaronshivers merged 1 commit into
masterfrom
codex/fix-national-ice-cream-day
Aug 1, 2026
Merged

aaronshivers merged 1 commit into
masterfrom
codex/fix-national-ice-cream-day

Conversation

@aaronshivers

Copy link
Copy Markdown
Owner

Summary

Calculate National Ice Cream Day as the third Sunday of July instead of treating July 21 as a fixed annual date.

Key Changes

  • move National Ice Cream Day to the shared calculated-holiday definition
  • add exact-date regression coverage across years where the third Sunday shifts
  • update the holiday-disable example to match the calculated definition

Testing

  • pytest -q — 24 passed
  • black --check . — passed
  • flake8 . — passed
  • npm run worker:verify — parity, smoke, and Wrangler dry-run bundle passed
  • generated dates from 1900 through 2100 — exactly one third Sunday per year
  • mypy . — reports four pre-existing errors in untouched files

Remaining / Open Items

None for this slice.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
calendar 479fb34 Aug 01 2026, 02:04 AM

@aaronshivers
aaronshivers merged commit 39db72b into master Aug 1, 2026
2 checks passed
@aaronshivers
aaronshivers deleted the codex/fix-national-ice-cream-day branch August 1, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant