[codex] fix observed holiday dates - #8
Merged
Merged
Conversation
aaronshivers
marked this pull request as ready for review
July 2, 2026 20:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes observed fixed-date federal holidays so the actual holiday remains on its calendar date and any shifted weekday observance is emitted as a separate
Holiday Name (Observed)event.This prevents cases like Independence Day 2026 from appearing as if Independence Day itself is July 3. The Python generator and Cloudflare Worker implementation now use the same behavior.
The regression coverage now checks every configured fixed-date federal holiday with observance behavior: New Year's Day, Juneteenth, Independence Day, Veterans Day, and Christmas Day.
This PR also includes the toolchain metadata changes present in the approved worktree from verification setup.
Validation
poetry run pytest -qpassed with 21 tests.npm run worker:verifypassed, including Worker syntax, Python/Worker parity, smoke test, and Wrangler dry-run bundle.