Repository navigation
feat: datetime/date comparisons for row_filters (#87) - #89
Merged
Merged
Conversation
Allow lt/lte/gt/gte/eq/neq predicates to set format = "datetime" or format = "date" so retain windows can use real timestamp cutoffs instead of year-prefix like workarounds. Thresholds validate at config load; unparseable cells fail closed. Co-authored-by: andy <andy@wearecrew.com>
normalize_timestamp_text was rewriting date-only thresholds like 2025-02-14 into 2025-02-14:00 by mistaking -14 for an offset. Co-authored-by: andy <andy@wearecrew.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #87:
lt/lte/gt/gte(andeq/neq) can compare ISO-8601 / Postgres timestamp text viaformat = "datetime", or calendar dates viaformat = "date".Example
Behavior
pg_dumpshapes (YYYY-MM-DD HH:MM:SS.fff+00,Tseparators,Z, short offsets)format = "datetime"are midnight UTCformatis omittedVerification
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test --all-targets --all-features(177 passed)Tests / docs
.dumplingconf.example, CHANGELOG, AGENTS.md