fix: add missing state getter to type definitions#358
Open
rossvz wants to merge 1 commit intoabandonware:masterfrom
Open
fix: add missing state getter to type definitions#358rossvz wants to merge 1 commit intoabandonware:masterfrom
state getter to type definitions#358rossvz wants to merge 1 commit intoabandonware:masterfrom
Conversation
The Noble class exposes a `state` getter property that returns the current Bluetooth adapter state, but this was missing from the TypeScript definitions. Only the internal `_state` property was declared. This adds: - `state` getter with proper typing - `NobleState` type alias for the state union type Fixes usage like `noble.state === "poweredOn"` which previously caused TypeScript error TS2551.
rzr
approved these changes
Jan 11, 2026
|
May I suggest to upstream the patch first to this other repo: cc: @stoprocent and @Apollon77 |
|
Thanks @rzr ... I think the fork from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stategetter property to TypeScript definitionsNobleStatetype alias for better reusabilityProblem
The Noble class exposes a
stategetter property (defined inlib/noble.jslines 72-79) that returns the current Bluetooth adapter state. However, the TypeScript definitions only declared the internal_stateproperty, not the publicstategetter.This caused TypeScript error TS2551 when using
noble.state:Solution
Added the
stategetter declaration alongside the existing_statedeclaration, and created aNobleStatetype alias for the state union type.Test plan
noble.state === "poweredOn"🤖 Generated with Claude Code