scope.c: use mutex_lock_killable to prevent unkillable processes#3
Open
tomvanbraeckel wants to merge 1 commit intoabbradar:masterfrom
Open
Conversation
When doing rmmod quickly after insmod, a race condition causes the code to wait for the lock forever so it hangs until the next reboot. This commit changes mutex_lock to mutex_lock_killable so at least the user can kill the userspace process waiting for the driver. Even though this is not a permanent proper fix, it makes the issue a lot less annoying because it removes the need for a full system restart when this happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing rmmod quickly after insmod, a race condition causes
the code to wait for the lock forever so it hangs until the next reboot.
This commit changes mutex_lock to mutex_lock_killable so at least
the user can kill the userspace process waiting for the driver.
Even though this is not a permanent proper fix, it makes the issue a lot
less annoying because it removes the need for a full system restart when this happens.