Refactor Tennis Game2 <Typescript>#2
Open
abdullahashraf-dev wants to merge 35 commits into
Open
Conversation
…lseif statments and make it more clear
…al functon as it loop two times only for the two player
…r not add to player2
…oreBasedOnPlayerPoint direct
…he other is bigger than it and the condtions in same if conditon
…bigger than the other one and add the condtions in same if conditon
…res should be less than 4
…rs point swould be 1 in first two if and remove unused score var
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr contain refactoring the tennis game 2 across 35 commits following rule of small incremental changes and running tests after every change to ensure it does not break the existed logic
Tests: