Fix core request pipeline stability - #585
Merged
Merged
Conversation
RANGROO
marked this pull request as ready for review
July 18, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
physics_rawtelemetry before it enters the dialogue/LLM pipelineRoot cause
Several core request paths assumed optional globals and scalar payload values were always initialized. Raw physics telemetry could also fall through without an extension handler, and dynamic-profile updates performed LLM work from the web request lifecycle. Rechat control JSON was passed directly into PostgreSQL
to_tsquery, allowing syntax operators in metadata to produce malformed searches.Impact
These changes prevent avoidable PHP warnings and connector errors, keep raw telemetry from producing LLM requests, prevent malformed memory searches, and allow dynamic-profile updates to continue asynchronously without holding the game request open.
Validation
php vendor/bin/phpunit tests/CoreRequestStabilityTest.php(7tests,13assertions)git diff --checkphysics_rawrequest returnedX-CUSTOM-CLOSEin approximately 118 ms without connector errorsReview notes
The unstable push guard requires a PR because this touches
main.php,processor/comm.php, andservice/processors/. It also reported overlap with open PRs #581 (main.php) and #568 (lib/data_functions.php), so this remains a draft pending conflict and semantic review.