Skip to content

Fix core request pipeline stability - #585

Merged
RANGROO merged 1 commit into
unstablefrom
codex/fix-core-request-stability
Jul 18, 2026
Merged

Fix core request pipeline stability#585
RANGROO merged 1 commit into
unstablefrom
codex/fix-core-request-stability

Conversation

@RANGROO

@RANGROO RANGROO commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • stop unhandled physics_raw telemetry before it enters the dialogue/LLM pipeline
  • move dynamic-profile batch processing out of Apache requests and into the core service queue
  • sanitize memory full-text search terms and use the rechat origin line instead of control JSON
  • safely handle structured equipment metadata and optional timeout/TTS globals
  • add focused regression coverage for the corrected request paths

Root cause

Several core request paths assumed optional globals and scalar payload values were always initialized. Raw physics telemetry could also fall through without an extension handler, and dynamic-profile updates performed LLM work from the web request lifecycle. Rechat control JSON was passed directly into PostgreSQL to_tsquery, allowing syntax operators in metadata to produce malformed searches.

Impact

These changes prevent avoidable PHP warnings and connector errors, keep raw telemetry from producing LLM requests, prevent malformed memory searches, and allow dynamic-profile updates to continue asynchronously without holding the game request open.

Validation

  • php vendor/bin/phpunit tests/CoreRequestStabilityTest.php (7 tests, 13 assertions)
  • PHP syntax checks passed for all changed files
  • git diff --check
  • live physics_raw request returned X-CUSTOM-CLOSE in approximately 118 ms without connector errors
  • deployed dynamic-profile worker consumed an invalid test queue job without invoking an LLM
  • local HerikaServer UI returned HTTP 200 after deployment

Review notes

The unstable push guard requires a PR because this touches main.php, processor/comm.php, and service/processors/. It also reported overlap with open PRs #581 (main.php) and #568 (lib/data_functions.php), so this remains a draft pending conflict and semantic review.

@RANGROO
RANGROO marked this pull request as ready for review July 18, 2026 19:17
@RANGROO
RANGROO merged commit f28255a into unstable Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant