Harden NPC profile UI loading - #649
Merged
Merged
Conversation
RANGROO
marked this pull request as ready for review
July 31, 2026 16:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The NPC Profiles UI treated any iframe or list response as successful. A stale profile ID, incomplete response, overlapping request, or failed AJAX refresh could therefore appear as an empty or randomly unloaded profile with no visible explanation.
Validation
php -l ui/core/npc_master.phpgit diff --check/var/www/html/HerikaServerand verified the deployed checksum andwww-data:www-dataownership.Review notes
This narrowly changes
ui/core/npc_master.php, which also overlaps open PRs #594 and #634. No database migration, generated binary, or new test file is included.