Add per-NPC event history and injection - #689
Merged
Merged
Conversation
RANGROO
marked this pull request as ready for review
August 11, 2026 00:33
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
inputtextevents for an NPC who is outside the current sceneProfile VersionslabelWhy
NPCs need to remember cross-scene handoffs, such as one NPC giving another a sweetroll, even when they are not currently together.
Maintainer Discussion
RANGROOortyler.maisterin Discord.Related PRs
Companion PrismaUI PR: https://github.com/Dwemer-Dynamics/CHIM/pull/126
Notes
inputtextevent/context path.infolocare excluded from both History rows and its type selector.ui/core/npc_master.phpalso overlaps draft PR Add persistent and repeatable NPC tasks #594, but this change is scoped to event history/injection rather than persistent NPC tasks.unstable:debug/db_updates.phpcallssql::escapeLiteral(), which is absent from the active test database class.Validation
php -l ui/api/chim_npc_manager.phpnode --check ui/js/npc_event_history.jsgit diff --checkui/adventurelog.phpexactlyinfolocin rows or filter optionschatreturned onlychat; requestinginfolocreturned zero rowsinputtextinject/read/delete round trip usingDorthe gave Alvor a sweetroll., with the temporary row removed from both historiesBackground Life->History