Compact vanilla NPC action tools - #692
Draft
RANGROO wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
action,mode,target,item, andamount.Grouped action modes
Handle_Crime:add_bounty,arrest,forgive,collect_bounty_paymentStart_Combat:lethal,brawlFollow:follow_actor,follow_player,approach_playerSet_Pace:faster,slowerGive:item,goldExchange:trade,receive_giftPerform_Gesture:drink_gesture,toasttargetnow consistently carries an actor, recipient, or destination;itemcarries an actual item or action detail; andamountcarries a positive quantity. JSON connectors receive a generatedmodeenum containing only active grouped variants plus blank for Talk and individual actions.Validation
ActionCatalogTest.php: 13 tests, 187 assertionsCoreRequestStabilityTest.php: 8 tests, 25 assertionsActionActorTargetRefTest.php: 2 tests, 4 assertionsProfileConnectorTestsRegressionTest.php: 1 test, 1 assertiongit diff --checkPR_REQUIREDas expected for core runtime changes; it also reports overlap with Add persistent and repeatable NPC tasks #594 infunctions/functions.php,functions/json_response.php, andlib/core/action_catalog.phpCompatibility
mode.Scope and limits
unstablepush.