Make autonomous bored events grounded and Smart-only - #716
Merged
Conversation
RANGROO
marked this pull request as ready for review
August 22, 2026 05:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Regular Bored and Smart Bored had diverged into two user-selectable paths. The built-in profile already enabled Smart, while the generic Smart flow inherited the normal Director system prompt, dramatic examples, and rules encouraging new content, plot twists, foreshadowing, and tension. Smart also redirected before the old prompt-level probability check.
Maintaining the Regular toggle left an obsolete path and duplicated prompt behavior. Appending grounded bored rules to the creative Director prompt still gave the model contradictory instructions.
Implementation
Validation
Performance
Rejected bored events terminate before launching an LLM request. Accepted autonomous NPC bored events now always use the two-stage Director-to-NPC flow, so profiles that previously disabled Smart will incur the additional Director request by design. Smart Bored omits the generic Director examples and general rules, reducing its fixed prompt context; no live connector token benchmark was run. Reviewable diff: 378 changed lines across 17 source/test files.
Compatibility and parity
Deployment
Not deployed. No version bump, package, promotion, or release.
Manual limits
Prompt quality has not been A/B tested with a live model or in Skyrim. The migration has not been applied to a live installation. The profile UI removal was source/catalog validated but not rendered in a deployed browser; Claude UI delegation was unavailable because local authentication had expired.
Review notes
Open PR #709 overlaps main.php and the prompt file, and #710 overlaps database/profile files. This branch starts from current origin/unstable and keeps its changes confined to bored-event routing, prompts, probability, and removal of the obsolete toggle.