Preserve NPC profile list state after reloads - #718
Merged
Conversation
RANGROO
marked this pull request as ready for review
August 22, 2026 05:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Navigating to a later CHIM NPC Profiles page updated only the rendered DOM. The URL retained no page or filter state, so any save-adjacent reload rebuilt page 1 and forced users to find the NPC again.
Change
history.replaceStateCompatibility
Validation
php -l ui/core/npc_master.phpgit diff --check67243AD96F49BB856A85AA3C3F8FAC49EAC08FACD724DC50E040780A490713D7Dorthepersisted through reloadpage=999clamped to page 11 and corrected the URLembed=1page 5 persisted through reloadPerformance
No additional request is made during ordinary NPC Save. Pagination refresh retains the existing single bounded list request; the change only serializes the already-active list controls into the URL.
Review scope
One file, 64 additions and 30 deletions (94 changed lines). Draft PR because
ui/core/npc_master.phpalso has unrelated active work in PRs #690 and #594.Deployment
Deployed locally to
/var/www/html/HerikaServer/ui/core/npc_master.phpfrom commitb88c2875f4e2ff0d7966ce95fcac16fb42ed7b49for user testing.Limits
The live browser validation did not submit an NPC Save because that would alter local profile data. In-game behavior was not tested or changed. Config Hub tab reactivation and delete redirects remain outside this focused fix.