Support distinct profiles for same-named actors - #735
Draft
RANGROO wants to merge 6 commits into
Draft
Conversation
Collaborator
Author
Remote Game Lab evidenceThis earlier actor-key result has been superseded by the simplified |
Collaborator
Author
Remote Game Lab evidence — Name + RefID revisionValidated test: Passed:
Overall result: inconclusive. The fresh-save Manual AI Activate binding did not persist, so this run does not claim live activation or save/reload continuity. The failed fallback console commands are explicitly excluded from proof. The laptop database, 12 server files, DLL, UI state, services, harness config, and game processes were restored afterward. The validated Game Lab result and evidence hashes are stored under test ID |
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Name [RefID: XXXXXXXX]identity for same-named NPC profilesmd5(Name [RefID]); retain legacymd5(name)only when no RefID existsactor_keycolumns, indexes, API fields, metadata, and UI presentationmetadata.modsMigration
npc_actor_identityversion20260824003Validation
20260824003, zero actor-key columns, one display-identity unique index, and HTTP 200NpcMaster::createproduced:Bandit [RefID: FF00AB01]->10fa69e082d9597494b9144c31e9efaeBandit [RefID: FF00AB02]->bc8513f2a3071a5d71bc53b5a9f70ebemetadata.mods = ["Skyrim.esm"]git diff --checkpassedLocal deployment
Deployed the 12 changed server files and migration to
/var/www/html/HerikaServerinDwemerAI4Skyrim3.The migration is active. The updater still reaches an unrelated existing later
eventlog_view/sessdependency error.Game Lab result
Test
20260825T032837797Z-0a8d6b1eis validated as inconclusive overall because fresh-save live activation and save/reload continuity were not completed. The server identity path, schema, UI, mod-source retention, and safety checks passed. The laptop was fully restored afterward.Counterpart CHIM PR: Dwemer-Dynamics/CHIM#165
Review notes
Manual review is required. The push guard reports active/open-PR overlap in shared runtime, migration, prompt, and NPC-manager files, including #734, #733, #725, #709, #704, #690, #594, #568, and #536.
Test-suite limit
The full PHPUnit run completed with 268 tests and 2,617 assertions but did not pass: 16 errors, 2 failures, and 1 warning from existing environment/baseline issues such as unavailable Windows PostgreSQL, missing ZipArchive, a missing Oghma test dependency, and unrelated faction failures. Focused actor-identity probes passed.