Skip to content

Describe Brawl as unarmed non-lethal combat - #738

Open
RANGROO wants to merge 2 commits into
unstablefrom
codex/vanilla-player-brawls
Open

Describe Brawl as unarmed non-lethal combat#738
RANGROO wants to merge 2 commits into
unstablefrom
codex/vanilla-player-brawls

Conversation

@RANGROO

@RANGROO RANGROO commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • describe Brawl consistently as an agreed, bare-fisted, non-lethal fight in English and German
  • keep both the player and nearby NPCs available as valid brawl targets
  • distinguish Brawl from lethal Attack without exposing internal runtime mechanics
  • update the built-in action seed and migration 20260825001
  • migrate customized Brawl rows only when both their description and parameter schema still match the old defaults

Companion game-plugin PR

Validation

  • php -l passed for all four changed PHP files
  • php vendor/bin/phpunit tests/CoreRequestStabilityTest.php — 7 tests, 13 assertions passed
  • focused action-schema probe confirmed Brawl accepts the player or a nearby NPC
  • both migration statements executed successfully inside a PostgreSQL transaction and were rolled back
  • core_action_seed.sql imported 53 rows successfully inside a PostgreSQL transaction and was rolled back

Full-suite baseline limits

The full Windows PHPUnit run reached 268 tests but is not clean on this host: 16 environment/harness errors (PostgreSQL setup and missing Zip extension), 2 unrelated existing assertion failures, and 1 missing-test-class warning. No changed-path failure was observed.

Limits

  • not deployed
  • paired in-game behavior requires the companion CHIM PR

@RANGROO RANGROO changed the title Make Brawl player-only and unarmed Describe Brawl as unarmed non-lethal combat Aug 25, 2026
@RANGROO
RANGROO marked this pull request as ready for review August 26, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant