Many changes#11
Open
cweiske wants to merge 40 commits into
Open
Conversation
When the configuration file does not exist, it is automatically created during runtime now and not on installation. Also, the correct user config directory is used, according to the operating system rules via the "appdirs" library. Resolves: abhimanyuPathania#5
Resolves: abhimanyuPathania#8
- Split configuration loading and validation - Setting configuration values does not require a valid configuration anymore - Configuration file is only written when something is changed - A full configuration file is written each time, so there can be no partially invalid config files anymore - Passing the source_dir as "normal" command line parameter (without "set") does not change config anymore - source_dir must not be set in config file and may be passed as command line parameter Resolves: abhimanyuPathania#4 Resolves: abhimanyuPathania#6
It has been shut down in 2019: https://en.wikipedia.org/wiki/LyricWiki#Edit_lock_and_closure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a couple of changes to lyrico to fix some bugs and adjust it to my needs.
I'd like to hear your opinion. Feel free to pick the changes you like.
Two of them are in separate branches and separate pull requests already.