feat: add complementary import-x rules to shared base config#602
Merged
Conversation
Adds eight import-x rules that complement (rather than duplicate) the existing strict-TypeScript and unused-imports setup: - no-duplicates, no-self-import, no-useless-path-segments, no-empty-named-blocks, no-mutable-exports - no-relative-packages (monorepo boundary discipline) - consistent-type-specifier-style (prefer-top-level) - no-extraneous-dependencies, with a devDependencies allowlist for tests, configs and scripts. Disabled in flavour-vitest and flavour-config-files for explicit overlays. Also updates the four existing import rule doc URLs to point at the new import-x repo.
André L. (WipeAir)
force-pushed
the
claude/import-x-rules-review
branch
from
995f00a to
35252bc
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds eight
eslint-plugin-import-xrules to@abinnovision/eslint-config-basechosen to complement (not duplicate) the existing strict-TypeScript andunused-importssetup:no-duplicates,no-self-import,no-useless-path-segments,no-empty-named-blocks,no-mutable-exports,no-relative-packages(monorepo boundary discipline),consistent-type-specifier-style(prefer-top-level), andno-extraneous-dependencieswith a dev-allowlist for tests/configs/scripts. The latter is explicitly disabled inflavour-vitestandflavour-config-filesfor consumers that overlay those configs on different file globs. Also refreshes the four pre-existing import rule doc URLs to point at the newun-ts/eslint-plugin-import-xrepo.Note:
no-extraneous-dependenciesmay surface phantom-dependency warnings in downstream repos that weren't previously checked.Test plan
yarn workspace @abinnovision/eslint-config-base build(rule keys/options type-check)yarn turbo lint:check --forceacross the monorepo (all 4 packages clean)