Skip to content

Release/1.2.17 - #1315

Merged
sacOO7 merged 1 commit into
mainfrom
release/1.2.17
Nov 11, 2025
Merged

sacOO7 merged 1 commit into
mainfrom
release/1.2.17

Conversation

@sacOO7

@sacOO7 sacOO7 commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Released version 1.2.17.
    • Updated NewtonSoft dependency.
    • Fixed Unity NewtonSoft dependency compatibility.
    • Updated copyright year to 2025.

@coderabbitai

coderabbitai Bot commented Nov 10, 2025

Copy link
Copy Markdown

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Version 1.2.17 release with changelog entry, assembly metadata updates, and runtime version string bumps from 1.2.16 across multiple project files.

Changes

Cohort / File(s) Summary
Release Documentation
CHANGELOG.md
Added changelog entry for version 1.2.17 (2025-11-10) with merged pull requests: ECO-5584 (NewtonSoft upgrade) and ECO-5624 (unity NewtonSoft dependency fix)
Assembly Metadata
src/CommonAssemblyInfo.cs
Updated AssemblyVersion, AssemblyFileVersion, and added AssemblyInformationalVersion to 1.2.17; added AssemblyCopyright for 2025; replaced FAKE-generated header with Cake-generated style
Runtime Version
unity/Assets/Ably/version.txt
Bumped version string from 1.2.16 to 1.2.17

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

These are straightforward version number updates across metadata and documentation files with no logic changes or behavioral modifications.

Poem

🐰 Hop and bump, we've done it well,
One-point-two-one-seven bells,
Version strings now shiny bright,
Assembly info feels just right!
Release day hops with cheer,
Changelog updates, crystal clear!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'Release/1.2.17' clearly and specifically describes the main purpose: releasing version 1.2.17, which is directly supported by the changeset containing version bumps across CHANGELOG.md, CommonAssemblyInfo.cs, and version.txt files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/1.2.17

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 29e56a2 and 05f1b4e.

⛔ Files ignored due to path filters (1)
  • unity/Assets/Ably/Plugins/IO.Ably.dll is excluded by !**/*.dll
📒 Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • src/CommonAssemblyInfo.cs (1 hunks)
  • unity/Assets/Ably/version.txt (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
CHANGELOG.md

9-9: Bare URL used

(MD034, no-bare-urls)


10-10: Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (2)
src/CommonAssemblyInfo.cs (1)

1-14: LGTM! Assembly metadata correctly updated for version 1.2.17.

All version attributes (AssemblyVersion, AssemblyFileVersion, and AssemblyInformationalVersion) are consistently set to 1.2.17, and the copyright year has been appropriately updated to 2025.

CHANGELOG.md (1)

3-11: LGTM! Changelog entry properly formatted for version 1.2.17.

The changelog entry follows the established format and correctly documents the release with links to the version tag, full changelog comparison, and the two merged PRs (ECO-5584 and ECO-5624).

Note: The static analysis warnings about "bare URLs" on lines 9-10 are false positives—these are properly formatted markdown links, not bare URLs.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sacOO7 sacOO7 changed the title Bumped up version to 1.2.17 Release/1.2.17 Nov 10, 2025
@github-actions
github-actions Bot temporarily deployed to staging/pull/1315/features November 10, 2025 14:13 Inactive
@github-actions
github-actions Bot temporarily deployed to staging/pull/1315/features November 10, 2025 14:39 Inactive
@sacOO7
sacOO7 requested a review from Copilot November 10, 2025 14:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the version from 1.2.16 to 1.2.17, updating version references across the codebase and documenting the release in the changelog.

  • Updated version number from 1.2.16 to 1.2.17 across Unity and .NET assembly files
  • Updated changelog with release notes for version 1.2.17, documenting merged PRs for NewtonSoft upgrades
  • Modified CommonAssemblyInfo.cs generation from FAKE to Cake build system with updated copyright year

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
unity/Assets/Ably/version.txt Updated Unity package version from 1.2.16 to 1.2.17
src/CommonAssemblyInfo.cs Updated assembly version attributes to 1.2.17, changed build tool from FAKE to Cake, and updated copyright to 2025
CHANGELOG.md Added release notes for version 1.2.17 with links to merged PRs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread unity/Assets/Ably/version.txt Outdated
@sacOO7
sacOO7 merged commit 89ab4cd into main Nov 11, 2025
20 checks passed
@sacOO7
sacOO7 deleted the release/1.2.17 branch November 11, 2025 13:02
@coderabbitai coderabbitai Bot mentioned this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants