ci: drop vestigial protoc and the rust-cache environment hash - #21
Merged
Merged
Conversation
Nothing in the dependency tree runs protoc: prost enters only through datafusion-proto, which ships pregenerated code and has no build script, and the bindings workflow has always built that crate without protoc on all three platforms. The installs only cost time and pinned a dormant action stuck on a deprecated Node runtime. rust-cache's environment hash includes rustc -vV of every installed toolchain, including the image-preinstalled stable that no job uses. Concurrent runner-image builds carry different stables, so the hash flips per runner draw and randomly breaks exact-key restores, which have no prefix fallback. Everything the hash protected is already in the explicit key: job env vars live in the hashed workflow file and the pinned toolchains come from rust-toolchain.toml, which rust-cache hashes on its own.
abnobdoss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.