Skip to content

ci: trim the macos and windows build scope #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
abnobdoss wants to merge 1 commit into
base: ci/windows-rust-lld
Choose a base branch
from
Draft

ci: trim the macos and windows build scope #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,13 +161,17 @@ jobs:
save-if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
add-rust-environment-hash-key: 'false'

# Folded in from the former build_with_no_default_features job so the
# core crate's feature gating is checked without a second dep closure.
- name: Build without default features
run: cargo build --locked -p iceberg --no-default-features

# cargo check is enough here: the ubuntu build-and-test job already
# fully builds and this job only guards feature-gated compile errors.
- name: Check without default features
run: cargo check --locked -p iceberg --no-default-features

# pyiceberg_core_rust is a fully serialized ~1m40s tail on both
# runners (including its cdylib link), and the Bindings Python CI
# workflow already compiles the same crate on windows-latest and
# macos-latest for every code PR.
- name: Build
run: make build
run: cargo build --locked --all-targets --all-features --workspace --exclude pyiceberg_core_rust

# Checks each crate individually to catch missing feature declarations that
# are otherwise masked by Cargo's feature unification across the workspace.
Expand Down
Loading