Skip to content

Fix read receipt update even if conversation fails #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aboldguess wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix read receipt update even if conversation fails #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions frontend/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,9 +372,10 @@ function selectUser(name) {
selectedUser = name;
currentChannel = null; // hide channel context
clearUnread(name);
// Load the conversation then explicitly notify the server that we've
// displayed these messages to ensure read receipts and counters update.
loadMessages().then(() => markMessagesSeen(name));
// Load the conversation. Regardless of success or failure, inform the
// server that we've displayed these messages so read receipts and counters
// update correctly even if the history fails to render.
loadMessages().finally(() => markMessagesSeen(name));
}

// Verify the user is logged in before showing the dashboard
Expand Down