Fix CLI stdin race before SDK 0.1.6 release - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short
agentbox sandbox execcommand can exit before the CLI closes piped stdin. Envd then returnsNotFoundfor the process; the SDK currently converts that into a genericSandboxError, so the CLI reports a failure even though the command succeeded.Map missing process IDs in
sendStdinandcloseStdintoCommandNotFoundError, and let the CLI treat that result as normal process completion while retaining failures for other errors. This fixes the reproducible non-interactive KVM release smoke for SDK 0.1.6.Validation:
pnpm format:check,pnpm lint,pnpm typecheck,pnpm test,make go-check, reproduciblemake generate, release artifact build/install checks, and the completetest-release-runtime.shsuite against the dev KVM runtime (JavaScript, Python, Go, CLI, private traffic, template build).