Fix Blazorise validation message localization for attribute placeholders (MinLength) #24524
Conversation
Introduced AbpValidationMessageLocalizerAttributeFinder to replace the default IValidationMessageLocalizerAttributeFinder with a singleton implementation. Updated AbpBlazoriseUIModule to register the new service, enhancing support for localized validation messages in Blazorise UI.
There was a problem hiding this comment.
Pull request overview
This pull request fixes Blazorise validation message localization for attribute placeholders, specifically for the MinLength validation attribute. The fix provides a custom implementation of IValidationMessageLocalizerAttributeFinder that properly extracts placeholder values from validation messages.
Key Changes:
- Added a new
AbpValidationMessageLocalizerAttributeFinderclass that implements placeholder extraction logic using regex - Registered the custom finder as a singleton service, replacing the default Blazorise implementation
- Enabled proper localization of validation messages containing dynamic placeholders like
{0},{1}, etc.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| framework/src/Volo.Abp.BlazoriseUI/Utilities/AbpValidationMessageLocalizerAttributeFinder.cs | New utility class implementing IValidationMessageLocalizerAttributeFinder with regex-based placeholder extraction logic |
| framework/src/Volo.Abp.BlazoriseUI/AbpBlazoriseUIModule.cs | Registers the custom attribute finder as a singleton service replacement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| var pattern = placeholderIndices.Aggregate(second, (current, index) => current.Replace("{" + index + "}", "(.+)")); | ||
|
|
||
| var valueMatch = Regex.Match(first, pattern); |
There was a problem hiding this comment.
The regex pattern on line 39 replaces placeholder indices but does not escape special regex characters that might be present in the localized string. If the 'second' parameter contains regex special characters (like '.', '*', '+', etc.), it could lead to incorrect pattern matching or regex errors. Consider escaping the 'second' string before using it in regex operations.
No description provided.