Skip to content

Conversation

@maliming
Copy link
Member

@maliming maliming commented Jan 3, 2026

This is different from the modal in permissions. We should be able to continue setting resource permissions for roles and the users under the roles.

Copilot AI review requested due to automatic review settings January 3, 2026 03:02
@maliming maliming added this to the 10.1-final milestone Jan 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a bug in the ResourcePermissionManager.SetAsync method where the early return condition was too broad. Previously, the method would return early if the permission's grant status matched the desired status, without verifying which provider granted it. This caused the method to skip setting permissions when they were already granted by a different provider than the one specified.

Key Changes:

  • Enhanced the early return condition to verify both the grant status AND that the specific provider/key combination already has the permission set before returning early

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rel-10.1@e66d88d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../PermissionManagement/ResourcePermissionManager.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             rel-10.1   #24531   +/-   ##
===========================================
  Coverage            ?   51.00%           
===========================================
  Files               ?     3378           
  Lines               ?   110720           
  Branches            ?     8426           
===========================================
  Hits                ?    56477           
  Misses              ?    52501           
  Partials            ?     1742           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maliming maliming requested a review from yagmurcelk January 3, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants