Skip to content

Migrate artifact icons to native Tabler names#930

Merged
abrignoni merged 1 commit into
mainfrom
tabler-icon-migration
Jul 6, 2026
Merged

Migrate artifact icons to native Tabler names#930
abrignoni merged 1 commit into
mainfrom
tabler-icon-migration

Conversation

@abrignoni

@abrignoni abrignoni commented Jul 6, 2026

Copy link
Copy Markdown
Owner

Follow-up to #929 (Tabler icons in the HTML report) — the ALEAPP counterpart of iLEAPP's abrignoni/iLEAPP#1640.

What changed (89 files, 119 icon values)

Every artifact_icon still carrying a Feather name is rewritten to the exact Tabler name the feather_to_tabler_icon_names.json shim already resolves it to. Includes the fitbit.py _art() helper's positional "watch""device-watch" (the one non-literal metadata construct).

Top renames: message-square→message (57), image→photo (29), info→info-circle (6), grid→layout-grid (4), bar-chart-2→chart-bar (4), plus voicemail→record-mail, chrome→brand-chrome, log-in→login-2, check-square→square-check, …

Rendering: identical for 117 of 119 — two deliberate improvements

Verified through the actual report.py resolution (shim branch skips the correction map; native branch applies it): 117 of 119 render the exact same SVG before and after. The two exceptions are the book-open artifacts (DuckDuckGo / Ornet Browser "Open Tabs"): they previously rendered book.svg (closed book, because the shim branch bypasses the book→book-2 correction) and now render book-2.svg (open book) — restoring the original Feather book-open intent.

Full conversion audit (no invented mappings)

  • AST-compared every touched file's __artifacts_v2__ main-vs-branch: no metadata field other than artifact_icon changed anywhere
  • Every old value verified genuinely non-native and present in the shim; every new value equals the shim's mapping exactly (0 invented) and its SVG exists on disk in assets/tabler_icons/
  • The 86 icon-only files contain no changed line other than artifact_icon lines (diff-level check)
  • Deepseek_ChatMessages.py: no live html reference remains after the unused-import removal (AST-verified)

Starting point vs iLEAPP

ALEAPP was already clean where iLEAPP wasn't: 0 icon-less artifacts, 0 broken names, 0 runtime-named report modules — a pure rename pass, no new icon assignments needed.

Lint (CI lints every changed file)

Two touched files carried small pre-existing findings, fixed with zero-behavior edits:

  • usagestatsVersion.py: underscore-prefixed unused arguments
  • Deepseek_ChatMessages.py: unused args prefixed; unused import html removed (only referenced inside a commented-out block); two kept-for-reference triple-quoted string statements converted to real comments; inline # pylint: disable=broad-exception-caught on the four existing except Exception handlers (repo precedent, e.g. fitbit.py)

Validation

  • py_compile clean on all 89 files
  • PYTHONPATH=. pylint --disable=C,R on all 89 changed files: 10.00/10
  • PluginLoader: 583 artifacts load; every icon is a native bundled Tabler name
  • No CRLF files among the touched set (checked before writing)

With Tabler icons in the HTML report (PR #929), move artifact metadata
to native Tabler icon names instead of relying on the feather-to-tabler
translation shim. 119 artifact_icon values across 89 files rewritten to
the exact name the shim already resolves them to, so rendering is
identical; includes the fitbit _art() helper's "watch" -> "device-watch".

Because CI lints every changed file, small pre-existing pylint findings
in two touched files are fixed with zero-behavior edits:
- usagestatsVersion.py / Deepseek_ChatMessages.py: underscore-prefix
  unused arguments; remove unused "import html" (only referenced inside
  a commented-out block)
- Deepseek_ChatMessages.py: convert two kept-for-reference triple-quoted
  string statements to comments; inline broad-exception-caught disables
  (repo precedent) on the four existing "except Exception" handlers

All 583 artifacts now carry a native bundled Tabler icon name.
@abrignoni abrignoni merged commit 8e6e62d into main Jul 6, 2026
2 checks passed
@abrignoni abrignoni deleted the tabler-icon-migration branch July 6, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant