sysShutdown: convert to @artifact_processor (closes out the LAVA conversion)#347
Merged
Conversation
Closes out the RLEAPP LAVA conversion: sysShutdown had v2 metadata (legacy 'function' key) but a self-reporting body with no LAVA output. Split into two artifact_processor artifacts matching the original reports — Sysdiagnose - Shutdown Log Processes (Timestamp/Entry Number/PID/Path/ Source File) and Sysdiagnose - Shutdown Log Reboots (Timestamp/Reboot Number/Source File) — sharing one verbatim parse helper. - context form, output_types standard, Timestamp typed datetime (UTC via convert_ts_int_to_utc; drops the no-op convert_utc_human_to_timezone 'UTC' wrap) - per-row Source File stays extraction-relative via context.get_relative_path (preserves #346 behavior) - preserves @KevinPagano3 attribution and 2024-02-13 creation date - pylint --disable=C,R 10.00; loader 312 -> 313; fixture-tested via .__wrapped__ (per-file entry/reboot numbering unchanged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sysShutdown.pywas the last artifact with a legacy self-reporting body: it had__artifacts_v2__metadata (using the old"function": "get_sysShutdown"key) but built its ownArtifactHtmlReport/tsv/timeline and produced no LAVA output. It slipped through the LAVA conversion sweep (#290–#343). This converts it to the modern pattern, so every RLEAPP artifact is now on@artifact_processor.Changes
_parse_shutdown_loghelper; the regex parsing logic is preserved verbatim (per-file entry/reboot numbering unchanged).def x(context)),output_types: standard, returns(data_headers, data_list, source_path).datetime, UTC viaconvert_ts_int_to_utc— drops the no-opconvert_utc_human_to_timezone(..., 'UTC')wrap (already-UTC aware datetime).context.get_relative_path(preserves sysShutdown: shorten per-row Source File paths (follow-up to #345) #346 behavior); returnedsource_pathis relativized centrally by the decorator (Report extraction-relative source paths from artifact_processor #345).Validation
PYTHONPATH=. pylint --disable=C,R scripts/artifacts/sysShutdown.py→ 10.00.__wrapped__on a syntheticshutdown.log: UTC-aware timestamps, correct entry/reboot numbering across multiple SIGTERM blocks, relative Source File in every rowtimestamp,entry_number,pid,path,source_file,reboot_number— all safe🤖 Generated with Claude Code