BugFix error AI Gen in IOS 14, Album Records NAD and some column not found#1361
Closed
AkagaRianma wants to merge 6 commits into
Closed
BugFix error AI Gen in IOS 14, Album Records NAD and some column not found#1361AkagaRianma wants to merge 6 commits into
AkagaRianma wants to merge 6 commits into
Conversation
buf fix if column 'score' not exists in table completion_cache_engagement to avoid failing the query
buf fix if column 'zGenAlbum.ZCREATORBUNDLEID' not exists to avoid failing the query
Collaborator
|
Closing this as superseded/conflicting. This PR has many files together which makes conflicts and overlaps even more likely. The MapsSync, ParseCD Cache, and Health fixes have already landed in newer PRs, and the remaining Photos column-guard idea should be handled separately from current main using the existing does_column_exist_in_db helper. This PR now contains stale overlap and lint issues, so it is not safe to merge as-is. Photo stuff might possibly be addressed in #1499 but if not, then this should get looked at and opened into a new focused PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff before and after.docx
dataset: https://digitalcorpora.s3.amazonaws.com/corpora/scenarios/magnet/2021%20CTF%20-%20iOS.zip
I want to fix Ph17GenAIDetected.py so that it doesn't show error when parsing on IOS < 18. I also want to fix Ph20AlbumsNAD.py so that it can parse on IOS 14. I also added some fixes for missing columns on IOS 14 when parsing sqlite databases. I prioritize the fixes in Ph17GenAIDetected.py and Ph20AlbumsNAD.py files.