Shorten per-row Source File paths (follow-up to #1656) + dmss data_list fix#1657
Merged
Conversation
Follow-up to #1656 (central source_path shortening): these artifacts also place the absolute on-disk path inside a per-record Source File column. Wrap the row-inserted copy with context.get_relative_path. - appItunesmeta: parent directory of the iTunesMetadata plist - voiceTriggers: the info json path - dmss: the media file path; also fixes a pre-existing bug where the function returned data_headers twice, discarding the built data_list entirely (the artifact output its own headers as rows). Audit note: all other flagged candidates were verified false positives - BeReal, burnerCache, discord_cache, tikTok, discordChats, walStrings, mobileInstallb, sysShutdown and booking already shorten via their own helpers or emit device-side paths/basenames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counterpart of ALEAPP #932: the central fix in #1656 can't reach absolute paths embedded in per-record Source File columns. Full audit of all artifact functions found only 3 true positives (everything else already shortens via helpers — BeReal's
relative_to, discordChats/walStrings/mobileInstallb/sysShutdown viacontext.get_relative_path, burnerCache/discord_cache via seeker file_infos — or emits device paths/basenames):return data_headers, data_headers, ...returned the headers tuple as the data list, discarding every built row. Now returnsdata_list.Testing: pylint 10.00/10 on all 3, byte-compile clean.