Change ilapfuncs.get_sqlite_db_records() to a generator#1673
Open
bconstanzo wants to merge 2 commits into
Open
Change ilapfuncs.get_sqlite_db_records() to a generator#1673bconstanzo wants to merge 2 commits into
bconstanzo wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the changes discussed in issues #1433 and #1306, and goes beyond what PR #1318 proposed.
I tried to keep changes minimal everywhere, there are a few NOTE comments where I noticed things that could be improved, left for a sunnier day in the future.
Not sure it's in the final and best form possible, but it is a step in the general direction to work with generators.