-
-
Notifications
You must be signed in to change notification settings - Fork 362
Keep AI commands out of Suggestions #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -412,14 +412,15 @@ so the sectioned view stays 1:1 with the flat selection. | |
| ### Suggestions | ||
|
|
||
| `LauncherSuggestions.select` chooses at most five from every visible entry that is not a favorite, a | ||
| meeting or Tinycast itself: | ||
| meeting, an AI command or Tinycast itself. AI is the lowest priority, so Quick AI and AI Chat are | ||
| never suggested, however often they are opened: | ||
|
Comment on lines
+415
to
+416
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Describe AI entries as excluded, not lowest-priority.
As per path instructions, “ 🤖 Prompt for AI AgentsSource: Path instructions |
||
|
|
||
| 1. up to two apps or extensions installed in the last five minutes and never opened — | ||
| `AppEntry.installedAt` is the bundle's added-to-directory date; | ||
| 2. entries with a score above 1 and no bound shortcut, in empty-list order — a shortcut is already the | ||
| faster way in; | ||
| 3. while fewer than five, built-in commands with no alias or shortcut, by | ||
| `CommandID.suggestionPriority`: AI Chat, Clipboard History, Search Files, My Schedule, Search Emoji & | ||
| `CommandID.suggestionPriority`: Clipboard History, Search Files, My Schedule, Search Emoji & | ||
| Symbols, then Create Quicklink and Create Snippet. A command whose feature is off is absent from the | ||
| index, so it is never offered. | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: abue-ammar/tinycast
Length of output: 6619
🏁 Script executed:
Repository: abue-ammar/tinycast
Length of output: 41336
Cover the
AppIndex.suggestionsAI filter.Tests/fuzz-test.swiftcallsLauncherSuggestions.selectwith synthetic candidates. It does not callAppIndex.suggestions, which removes entries wheresettingsOwner == .ai. The test would still pass if that filter were removed. Add anAppIndex-level case with an AI-owned entry and assert that it is excluded.🤖 Prompt for AI Agents
Source: Path instructions