Set and display a version number #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll just follow the udev/systemd versioning scheme. This replaces the version number that was generated via 'git describe' and will facilitate building itsa from an archive where there is no .git/ directory. It is also trivial to override the version at compile time, e.g. $ make ITSA_VER=$(git describe --long | tail -c +2) Which will give a version like '001-0-g31cf44f' Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
There was a problem hiding this comment.
Pull Request Overview
This PR implements a static versioning system for the itsa application, replacing the dynamic git-based version generation. The version is now set to "001" following the udev/systemd versioning scheme, making it possible to build from source archives without a git repository while still allowing version overrides at compile time.
Key Changes:
- Replaced dynamic
GIT_VERSIONwith staticITSA_VERversion identifier - Added version display to usage information and API info output
- Updated build system to use the new versioning scheme
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/itsa.c | Updated version references from GIT_VERSION to ITSA_VER and added version display in usage and API info functions |
| src/Makefile | Replaced git describe command with static version "001" and updated compiler flags to define ITSA_VER instead of GIT_VERSION |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll just follow the udev/systemd versioning scheme.
This replaces the version number that was generated via 'git describe' and will facilitate building itsa from an archive where there is no .git/ directory.
It is also trivial to override the version at compile time, e.g.
$ make ITSA_VER=$(git describe --long | tail -c +2)
Which will give a version like '001-0-g31cf44f'