Prefer matching SystemC libdir before lib* fallback - #348
Open
eactor wants to merge 2 commits into
Open
Conversation
PR accellera-official#347 allows custom SystemC library directories by adding all ${SYSTEMC_HOME}/lib* directories to the search path. When multiple variants exist, prefer ${SYSTEMC_HOME}/${CMAKE_INSTALL_LIBDIR} first. While CCI and SystemC may use different install settings, this is our best available guess and avoids relying on glob order when both use the same configuration. The existing lib* search remains as fallback.
Do not add SYSTEMC_HOME-derived guesses when the user selects a package configuration directory. Otherwise an invalid explicit selection could silently resolve to another SystemC installation.
-DSystemCLanguage_DIR=... given
-> search only there
-> invalid => configure fails
not given
-> use SYSTEMC_HOME
-> preferred libdir
-> lib* guessing
Contributor
Author
|
Make explicit SystemCLanguage_DIR authoritative. -DSystemCLanguage_DIR=... given not given |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #347 allows custom SystemC library directories discovery by adding all ${SYSTEMC_HOME}/lib* directories to the search path.
When multiple variants exist within SystemC Home, prefer ${SYSTEMC_HOME}/${CMAKE_INSTALL_LIBDIR} first. This is our best available guess as the user probably uses the CMAKE_INSTALL_LIBDIR for both SystemC and CCI. This avoids relying on glob order for multiple lib* dirs.
The existing lib* search remains as fallback.