Remove export(PACKAGE <PackageName>) from CMakeLists - #115
Open
QuaternionsRock wants to merge 1 commit into
Open
Remove export(PACKAGE <PackageName>) from CMakeLists#115QuaternionsRock wants to merge 1 commit into
export(PACKAGE <PackageName>) from CMakeLists#115QuaternionsRock wants to merge 1 commit into
Conversation
maehne
approved these changes
Jun 2, 2025
maehne
left a comment
maehne
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @QuaternionsRock, for your detailed explanation in issue #114. For me, it is acceptable to remove these two export package lines, as there are nowadays better ways to build and use library dependencies from local build trees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #114.