sc_clock: check for NaN duty cycle - #174
Open
atalii wants to merge 1 commit into
Open
Conversation
Contributor
|
@atalii, could you please rebase on main? |
maehne
suggested changes
Aug 26, 2026
maehne
left a comment
maehne
left a comment
Contributor
There was a problem hiding this comment.
Checking for NaN makes sense, but use std::isnan() available since C++'11.
This is disallowed by §6.7.4 (b): The duty cycle shall lie between the limits 0.0 and 1.0, exclusive. The default duty cycle is 0.5. Signed-off-by: Tali Auster <me@tali.network>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A NaN duty cycle is disallowed by §6.7.4 (b):
Since the existing behavior for out-of-range duty cycles is to set it to 0.5, I believe it's appropriate to do the same here. Emitting a warning may also be desirable.
(See a failing test-case here: 0db6cff. I have confirmed that this patch fixes the failure.)